Hi Rafael,

On 11/17/25 19:46, Rafael J. Wysocki wrote:

On Mon, Nov 17, 2025 at 6:01 PM Ben Horgan [off-list ref] wrote:

quoted

Define a cleanup helper for use with __free to release the acpi table when
the pointer goes out of scope. Also, introduce the helper
acpi_get_table_ret() to simplify a commonly used pattern involving
acpi_get_table().

These are first used in a subsequent commit.

Reviewed-by: Gavin Shan <redacted>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Shaopeng Tan <redacted>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Tested-by: Fenghua Yu <fenghuay@nvidia.com>
Tested-by: Carl Worth <redacted>
Tested-by: Gavin Shan <redacted>
Tested-by: Zeng Heng <redacted>
Tested-by: Shaopeng Tan <redacted>
Signed-off-by: Ben Horgan <ben.horgan@arm.com>
---
 include/linux/acpi.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index a9dbacabdf89..1124b7dc79fd 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h

@@ -8,6 +8,7 @@
 #ifndef _LINUX_ACPI_H
 #define _LINUX_ACPI_H

+#include <linux/cleanup.h>
 #include <linux/errno.h>
 #include <linux/ioport.h>      /* for struct resource */
 #include <linux/resource_ext.h>

@@ -221,6 +222,17 @@ void acpi_reserve_initial_tables (void);
 void acpi_table_init_complete (void);
 int acpi_table_init (void);

+static inline struct acpi_table_header *acpi_get_table_ret(char *signature, u32 instance)

Maybe call this acpi_get_table_pointer() ?

Ok, can do.

quoted

+{
+       struct acpi_table_header *table;
+       int status = acpi_get_table(signature, instance, &table);
+
+       if (ACPI_FAILURE(status))
+               return ERR_PTR(-ENOENT);
+       return table;
+}
+DEFINE_FREE(acpi_put_table, struct acpi_table_header *, if (!IS_ERR_OR_NULL(_T)) acpi_put_table(_T))
+
 int acpi_table_parse(char *id, acpi_tbl_table_handler handler);
 int __init_or_acpilib acpi_table_parse_entries(char *id,
                unsigned long table_size, int entry_id,
--

Thanks,

Ben