Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

Hi Dragan

Oops, indeed I overlooked this message!

On 11/15/25 01:52, Dragan Simic wrote:

Hello Michael,

Thanks for the v2!  Please, see some remarks below.

On Friday, November 14, 2025 16:46 CET, michael.opdenacker@rootcommit.com wrote:

quoted

From: Michael Opdenacker <redacted>

I'm sorry for not mentioning it in my earlier responses, but this
line is redundant, because it duplicates the From value found in
the actual email message.

quoted

Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.

The "3S" version ("S" for "storage") just adds a 16 GB eMMC
and a "mask ROM" DIP switch to the "3" version.

[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html

Signed-off-by: Michael Opdenacker <redacted>
---
  Documentation/devicetree/bindings/arm/rockchip.yaml | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6aceaa8acbb2..cd249325a4d9 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml

@@ -86,6 +86,17 @@ properties:
            - const: asus,rk3288-tinker-s
            - const: rockchip,rk3288
  
+      - description: Asus Tinker Board 3
+        items:
+          - const: asus,rk3566-tinker-board-3
+          - const: rockchip,rk3566
+
+      - description: Asus Tinker Board 3S
+        items:
+          - const: asus,rk3566-tinker-board-3s
+          - const: asus,rk3566-tinker-board-3
+          - const: rockchip,rk3566
+
        - description: Beelink A1
          items:
            - const: azw,beelink-a1

I'm sorry again for not mentioning it in my earlier responses,
but shouldn't this addition be specified like below:

      - description: Asus Tinker Board 3/3S
        items:
          - enum:
	   - asus,rk3566-tinker-board-3
            - asus,rk3566-tinker-board-3s
          - const: rockchip,rk3566

... because the introduced .dts files define the actual board DTs,
by descending from the common .dtsi file, while they're compatible
in the sense of the 3S board variant extending the 3 variant.

Indeed, that's the way it should be, looking at the rest of the rockchip.yaml file.

I was too hypnotized by the section for the original Tinkerboard, which doesn't follow this either (I'll send a separate patch).
Thanks a lot!
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/