Re: [PATCH v7 1/7] dt-bindings: arm: Add support for Qualcomm TGU trace

On 05/11/2025 09:11, Songwei Chai wrote:

On 11/5/2025 3:49 PM, Krzysztof Kozlowski wrote:

quoted

On Mon, Nov 03, 2025 at 10:40:37PM -0800, Songwei Chai wrote:

quoted

The Trigger Generation Unit (TGU) is designed to detect patterns or
sequences within a specific region of the System on Chip (SoC). Once
configured and activated, it monitors sense inputs and can detect a
pre-programmed state or sequence across clock cycles, subsequently
producing a trigger.

I do not understand: You got review which you ignored and then you
removed pieces of this code to make it incorrect. Go back to previous
versions so you won't waste our time re-doing review.

Hi Krzysztof,

The previous reviewed-by is no longer applicable because in this 
version, we moved

the driver from /drivers/hwtracing/coresight/ to 
/drivers/hwtracing/qcom/. This means the

required compatible has changed from "/qcom,coresight-tgu/" to "/qcom,tgu/".

Since this involves changes to devicetree binding, i didn't not carry 
over the previous review tags.

And which part of changelog explains the exact reasons to drop review
tags? Not mentioning that changelog is almost impossible to find, buried
under 10 pages of some repetitive introduction

Did you read submitting patches?

Meanwhile apologize for the confusion caused by my oversight in not 
mentioning the dt-binding changes in the

You made many more changes to the binding - nothing explained, no
rationale for any of that.

All qcom coresight bindings are called coresight and I do not see reason
why this is being changed.

Best regards,
Krzysztof