Re: [PATCH v4 2/2] usb: dwc3: Add Google Tensor SoC DWC3 glue driver

On Sat, Nov 1, 2025 at 2:10 PM Greg Kroah-Hartman
[off-list ref] wrote:

On Fri, Oct 31, 2025 at 05:49:28PM -0700, Roy Luo wrote:

quoted

quoted

quoted

+         dr_role != DWC3_GCTL_PRTCAP_HOST) {
+             dev_warn(google->dev, "spurious pme irq %d, hibernation %d, dr_role %u\n",
+                      irq, google->is_hibernation, dr_role);

Should we limit this print and do we need this to be dev_warn? It may be
noisy wouldn't it.

Ack, will make it WARN_ONCE in the next version.

So you really want to panic your system if this happens (remember, the
HUGE majority of Linux systems run with panic-on-warn enabled)?

Please do not, handle the issue, dump a message to the log if you really
need to, and move on, don't crash.

thanks,

greg k-h

Thanks for pointing this out, I overlooked the panic-on-warn scenario.
This case is actually very rare, I haven't seen this on the field and I
feel it does no harm to the system even it it were to happen, having a
debug log should still be useful if we were to debug anything specific
to this interrupt. I will make it dev_dbg.

Thanks,
Roy Luo