Thread (30 messages) 30 messages, 4 authors, 2025-11-07
STALE242d

[PATCH net-next v3 4/4] net: ftgmac100: Add RGMII delay support for AST2600

From: Jacky Chou <jacky_chou@aspeedtech.com>
Date: 2025-11-04 04:47:20
Also in: linux-aspeed, linux-devicetree, lkml, netdev

Hi Andrew,

Thank you for your reply.
quoted
+	rgmii_tx_delay = DIV_ROUND_CLOSEST(rgmii_tx_delay,
rgmii_delay_unit);
quoted
+	if (rgmii_tx_delay >= 32) {
+		dev_err(&pdev->dev,
+			"The index %u of TX delay setting is out of range\n",
+			rgmii_tx_delay);
The index is not really interesting here, it is not something a DT author uses. It
is the delay in ps in the .dts file which is too big.
Agreed - the "index" isn't meaningful to DT authors.
I'll modify the error message to display the actual TX/RX delay value in picoseconds 
instead of the internal index, so it's clearer which DT value is too large.

Thanks,
Jacky

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help