[PATCH v2 13/25] media: nxp: imx8-isi: Drop unneeded v4l2_m2m_get_vq() NULL check
STALE348d
REVIEWED: 13 (13M)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2025-10-15 07:54:28
Also in:
imx, linux-media
Subsystem:
media input infrastructure (v4l/dvb), nxp i.mx 8m isi driver, the rest · Maintainers:
Mauro Carvalho Chehab, Laurent Pinchart, Linus Torvalds
Revision v2 of 2 in this series; 1 review trailer (1 from subsystem maintainers).
Revisions (2)
- v1 [diff vs current]
- v2 current
The v4l2_m2m_get_vq() function never returns NULL. The check may have been intended to catch invalid format types, but that's not needed as the V4L2 core picks the appropriate VIDIOC_S_FMT ioctl handler based on the format type, so the type can't be incorrect. Drop the unneeded return value check. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c
index 00afcbfbdde4..df14f12b3ad2 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c@@ -554,8 +554,6 @@ static int mxc_isi_m2m_s_fmt_vid(struct file *file, void *fh, struct vb2_queue *vq; vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type); - if (!vq) - return -EINVAL; if (vb2_is_busy(vq)) return -EBUSY;
--
Regards,
Laurent Pinchart