Re: [PATCH v4 10/28] KVM: TDX: Fold tdx_sept_drop_private_spte() into... | linux-arm-kernel

[PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 01/28] KVM: Make support for kvm_arch_vcpu_async_ioctl() mandatory · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 02/28] KVM: Rename kvm_arch_vcpu_async_ioctl() to kvm_arch_vcpu_unlocked_ioctl() · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 03/28] KVM: TDX: Drop PROVE_MMU=y sanity check on to-be-populated mappings · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 04/28] KVM: x86/mmu: Add dedicated API to map guest_memfd pfn into TDP MMU · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 04/28] KVM: x86/mmu: Add dedicated API to map guest_memfd pfn into TDP MMU · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 05/28] KVM: x86/mmu: WARN if KVM attempts to map into an invalid TDP MMU root · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 05/28] KVM: x86/mmu: WARN if KVM attempts to map into an invalid TDP MMU root · Huang, Kai <hidden> · 2025-10-30
[PATCH v4 06/28] Revert "KVM: x86/tdp_mmu: Add a helper function to walk down the TDP MMU" · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 07/28] KVM: x86/mmu: Rename kvm_tdp_map_page() to kvm_tdp_page_prefault() · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 08/28] KVM: TDX: Drop superfluous page pinning in S-EPT management · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 08/28] KVM: TDX: Drop superfluous page pinning in S-EPT management · Yan Zhao <hidden> · 2025-10-31
Re: [PATCH v4 08/28] KVM: TDX: Drop superfluous page pinning in S-EPT management · Sean Christopherson <seanjc@google.com> · 2025-10-31
[PATCH v4 09/28] KVM: TDX: Return -EIO, not -EINVAL, on a KVM_BUG_ON() condition · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 09/28] KVM: TDX: Return -EIO, not -EINVAL, on a KVM_BUG_ON() condition · Huang, Kai <hidden> · 2025-10-30
[PATCH v4 10/28] KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 10/28] KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte() · Yan Zhao <hidden> · 2025-10-31
[PATCH v4 11/28] KVM: x86/mmu: Drop the return code from kvm_x86_ops.remove_external_spte() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 11/28] KVM: x86/mmu: Drop the return code from kvm_x86_ops.remove_external_spte() · Huang, Kai <hidden> · 2025-10-30
[PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 13/28] KVM: TDX: Avoid a double-KVM_BUG_ON() in tdx_sept_zap_private_spte() · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 14/28] KVM: TDX: Use atomic64_dec_return() instead of a poor equivalent · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 15/28] KVM: TDX: Fold tdx_mem_page_record_premap_cnt() into its sole caller · Sean Christopherson <seanjc@google.com> · 2025-10-30
[PATCH v4 16/28] KVM: TDX: ADD pages to the TD image while populating mirror EPT entries · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 16/28] KVM: TDX: ADD pages to the TD image while populating mirror EPT entries · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 17/28] KVM: TDX: Fold tdx_sept_zap_private_spte() into tdx_sept_remove_private_spte() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 17/28] KVM: TDX: Fold tdx_sept_zap_private_spte() into tdx_sept_remove_private_spte() · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 18/28] KVM: TDX: Combine KVM_BUG_ON + pr_tdx_error() into TDX_BUG_ON() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 18/28] KVM: TDX: Combine KVM_BUG_ON + pr_tdx_error() into TDX_BUG_ON() · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 18/28] KVM: TDX: Combine KVM_BUG_ON + pr_tdx_error() into TDX_BUG_ON() · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 19/28] KVM: TDX: Derive error argument names from the local variable names · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 19/28] KVM: TDX: Derive error argument names from the local variable names · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 20/28] KVM: TDX: Assert that mmu_lock is held for write when removing S-EPT entries · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 20/28] KVM: TDX: Assert that mmu_lock is held for write when removing S-EPT entries · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 20/28] KVM: TDX: Assert that mmu_lock is held for write when removing S-EPT entries · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 21/28] KVM: TDX: Add macro to retry SEAMCALLs when forcing vCPUs out of guest · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 21/28] KVM: TDX: Add macro to retry SEAMCALLs when forcing vCPUs out of guest · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 21/28] KVM: TDX: Add macro to retry SEAMCALLs when forcing vCPUs out of guest · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 22/28] KVM: TDX: Add tdx_get_cmd() helper to get and validate sub-ioctl command · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 22/28] KVM: TDX: Add tdx_get_cmd() helper to get and validate sub-ioctl command · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 23/28] KVM: TDX: Convert INIT_MEM_REGION and INIT_VCPU to "unlocked" vCPU ioctl · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 23/28] KVM: TDX: Convert INIT_MEM_REGION and INIT_VCPU to "unlocked" vCPU ioctl · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 24/28] KVM: TDX: Use guard() to acquire kvm->lock in tdx_vm_ioctl() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 24/28] KVM: TDX: Use guard() to acquire kvm->lock in tdx_vm_ioctl() · Binbin Wu <hidden> · 2025-10-31
[PATCH v4 25/28] KVM: TDX: Don't copy "cmd" back to userspace for KVM_TDX_CAPABILITIES · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 25/28] KVM: TDX: Don't copy "cmd" back to userspace for KVM_TDX_CAPABILITIES · Huang, Kai <hidden> · 2025-10-30
[PATCH v4 26/28] KVM: TDX: Guard VM state transitions with "all" the locks · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 26/28] KVM: TDX: Guard VM state transitions with "all" the locks · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 26/28] KVM: TDX: Guard VM state transitions with "all" the locks · Yan Zhao <hidden> · 2025-10-31
Re: [PATCH v4 26/28] KVM: TDX: Guard VM state transitions with "all" the locks · Sean Christopherson <seanjc@google.com> · 2025-10-31
Re: [PATCH v4 26/28] KVM: TDX: Guard VM state transitions with "all" the locks · Yan Zhao <hidden> · 2025-11-03
[PATCH v4 27/28] KVM: TDX: Bug the VM if extending the initial measurement fails · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 27/28] KVM: TDX: Bug the VM if extending the initial measurement fails · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 27/28] KVM: TDX: Bug the VM if extending the initial measurement fails · Binbin Wu <hidden> · 2025-11-04
Re: [PATCH v4 27/28] KVM: TDX: Bug the VM if extending the initial measurement fails · Sean Christopherson <seanjc@google.com> · 2025-11-04
[PATCH v4 28/28] KVM: TDX: Fix list_add corruption during vcpu_load() · Sean Christopherson <seanjc@google.com> · 2025-10-30
Re: [PATCH v4 28/28] KVM: TDX: Fix list_add corruption during vcpu_load() · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · Huang, Kai <hidden> · 2025-10-30
Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · Yan Zhao <hidden> · 2025-10-31
Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · "Edgecombe, Rick P" <rick.p.edgecombe@intel.com> · 2025-10-31
Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · Sean Christopherson <seanjc@google.com> · 2025-11-04
Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups · Sean Christopherson <seanjc@google.com> · 2025-11-10

Re: [PATCH v4 10/28] KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte()

From: Yan Zhao <hidden>
Date: 2025-10-31 08:24:59
Also in: kvm, kvm-riscv, kvmarm, linux-coco, linux-mips, linux-riscv, linuxppc-dev, lkml, loongarch

On Thu, Oct 30, 2025 at 01:09:33PM -0700, Sean Christopherson wrote:

Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte() as a
step towards having "remove" be the only and only function that deals with

only and only?

removing/zapping/dropping a SPTE, e.g. to avoid having to differentiate
between "zap", "drop", and "remove".  Eliminating the "drop" helper also
gets rid of what is effectively dead code due to redundant checks, e.g. on
an HKID being assigned.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help