Thread (1 message) 1 message, 1 author, 2025-10-28

Re: [PATCH v5 04/23] gpio: aspeed: #undef field_{get,prep}() before local definition

flat view

From: Bartosz Golaszewski <hidden>
Date: 2025-10-28 14:20:28
Also in: linux-aspeed, linux-clk, linux-crypto, linux-edac, linux-gpio, linux-iio, linux-renesas-soc, linux-sound, lkml

On Mon, Oct 27, 2025 at 7:42 PM Geert Uytterhoeven
[off-list ref] wrote:
quoted hunk
Prepare for the advent of globally available common field_get() and
field_prep() macros by undefining the symbols before defining local
variants.  This prevents redefinition warnings from the C preprocessor
when introducing the common macros later.

Suggested-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
--
v5:
  - New.
---
 drivers/gpio/gpio-aspeed.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 7953a9c4e36d7550..ef4ccaf74a5b379e 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -32,7 +32,9 @@
 #include "gpiolib.h"

 /* Non-constant mask variant of FIELD_GET() and FIELD_PREP() */
+#undef field_get
 #define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
+#undef field_prep
 #define field_prep(_mask, _val)        (((_val) << (ffs(_mask) - 1)) & (_mask))

 #define GPIO_G7_IRQ_STS_BASE 0x100
--
2.43.0
Acked-by: Bartosz Golaszewski <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help