On 28/10/2025 12:14, Zhentao Guo wrote:

quoted

quoted

+properties:
+  compatible:
+    const: amlogic,s4-vcodec-dec
+
+  reg:
+    maxItems: 2
+
+  reg-names:
+    items:
+      - const: dosbus
+      - const: dmcbus

Is "bus" really name of this in datasheet?

No, it is not from the datasheet, in fact it was inherited from the
older SOCs. Do you have any suggestions about this?

dos, dmc

quoted

quoted

+
+  interrupts:
+    maxItems: 3
+
+  interrupt-names:
+    items:
+      - const: mailbox_0
+      - const: mailbox_1
+      - const: mailbox_2

Useless names, so just drop interrupt-names property.

Yes, we don't need the interrupt names. I'll drop them.

quoted

quoted

+
+  clocks:
+    maxItems: 3
+
+  clock-names:
+    items:
+      - const: vdec
+      - const: clk_vdec_mux
+      - const: clk_hevcf_mux
+
+  power-domains:
+    maxItems: 2
+
+  power-domain-names:
+    items:
+      - const: pwrc-vdec

Drop pwrc

quoted

+      - const: pwrc-hevc

Drop pwrc

Ok, I'll drop the two pwrc(s) above.

quoted

Missing iommus. I really doubt hardware works without IOMMU.

IOMMU is not supported by Amlogic SOCs, the decoder hardware needs to 
use contiguous memory.

I assume you speak about hardware, not drivers, so it is fine.

Best regards,
Krzysztof