Re: [PATCH 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189

On Wed, 2025-10-01 at 19:06 -0500, Rob Herring wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


On Fri, Sep 19, 2025 at 04:09:55PM +0800, Zhengnan Chen wrote:

quoted

From: "zhengnan.chen" <redacted>

Please fix your name here so the S-o-b matches.
ok, will fix it in the next version.

quoted

Add binding description for mt8189.

Signed-off-by: Zhengnan Chen <redacted>
---
 .../bindings/memory-controllers/mediatek,smi-common.yaml       | 2
++
 .../bindings/memory-controllers/mediatek,smi-larb.yaml         | 3
+++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-common.yaml
b/Documentation/devicetree/bindings/memory-
controllers/mediatek,smi-common.yaml
index 0762e0ff66ef..aac8368b210c 100644

--- a/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-common.yaml

+++ b/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-common.yaml

@@ -40,6 +40,8 @@ properties:
           - mediatek,mt8186-smi-common
           - mediatek,mt8188-smi-common-vdo
           - mediatek,mt8188-smi-common-vpp
+          - mediatek,mt8189-smi-common
+          - mediatek,mt8189-smi-sub-common

Perhaps some explanation what 'sub-common' is compared to just
'common'.
ok, will add relevant explanation in the next version.

quoted

           - mediatek,mt8192-smi-common
           - mediatek,mt8195-smi-common-vdo
           - mediatek,mt8195-smi-common-vpp

diff --git a/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-larb.yaml
b/Documentation/devicetree/bindings/memory-
controllers/mediatek,smi-larb.yaml
index 2e7fac4b5094..9a5dafd7c07e 100644

--- a/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-larb.yaml

+++ b/Documentation/devicetree/bindings/memory-

controllers/mediatek,smi-larb.yaml

@@ -27,6 +27,7 @@ properties:
           - mediatek,mt8183-smi-larb
           - mediatek,mt8186-smi-larb
           - mediatek,mt8188-smi-larb
+          - mediatek,mt8189-smi-larb
           - mediatek,mt8192-smi-larb
           - mediatek,mt8195-smi-larb

@@ -85,6 +86,7 @@ allOf:
             - mediatek,mt8183-smi-larb
             - mediatek,mt8186-smi-larb
             - mediatek,mt8188-smi-larb
+            - mediatek,mt8189-smi-larb
             - mediatek,mt8195-smi-larb

     then:

@@ -119,6 +121,7 @@ allOf:
               - mediatek,mt6779-smi-larb
               - mediatek,mt8186-smi-larb
               - mediatek,mt8188-smi-larb
+              - mediatek,mt8189-smi-larb
               - mediatek,mt8192-smi-larb
               - mediatek,mt8195-smi-larb

--

2.46.0