Thread (20 messages) 20 messages, 2 authors, 2025-10-20

Re: [PATCH v1 12/13] drm/mediatek: Add support for mt8189 mmsys driver probe

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2025-10-20 10:49:40
Also in: linux-devicetree, linux-mediatek, lkml

Il 20/10/25 09:40, Xiandong Wang ha scritto:
mmsys probe for mt8189

Signed-off-by: Xiandong Wang <redacted>
---
  drivers/gpu/drm/mediatek/mtk_ddp_comp.c  |  2 ++
  drivers/gpu/drm/mediatek/mtk_disp_ovl.c  | 40 ++++++++++++++++++++++++
  drivers/gpu/drm/mediatek/mtk_disp_ovl.h  |  2 ++
  drivers/gpu/drm/mediatek/mtk_disp_rdma.c |  8 +++++
  drivers/gpu/drm/mediatek/mtk_drm_drv.c   | 39 +++++++++++++++++++++++
  5 files changed, 91 insertions(+)
..snip..
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 4c19cffafd0f..9e6d949e5d17 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -187,11 +187,27 @@ static const unsigned int mt8188_mtk_ddp_main[] = {
  	DDP_COMPONENT_DITHER0,
  };
  
+static const unsigned int mt8189_mtk_ddp_main[] = {
+	DDP_COMPONENT_OVL0,
+	DDP_COMPONENT_RDMA0,
+	DDP_COMPONENT_COMP0_OUT_CB4,
+};
+
+static const unsigned int mt8189_mtk_ddp_ext[] = {
+	DDP_COMPONENT_OVL1,
+	DDP_COMPONENT_RDMA1,
+	DDP_COMPONENT_COMP0_OUT_CB5,
+};
NACK. Please use OF Graph only. Stop hardcoding paths in mediatek-drm.

Regards,
Angelo

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help