Re: [PATCH v3 03/26] of/irq: Add IRQ affinity reporting interface

On Thu, 09 Oct 2025 17:49:59 +0100,
Jonathan Cameron [off-list ref] wrote:

On Mon, 22 Sep 2025 09:28:10 +0100
Marc Zyngier [off-list ref] wrote:

quoted

Plug the irq_populate_fwspec_info() helper into the OF layer
to offer an IRQ affinity reporting function.

Signed-off-by: Marc Zyngier <maz@kernel.org>

Trivial comment inline but I don't care that much.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

quoted

---
 drivers/of/irq.c       | 20 ++++++++++++++++++++
 include/linux/of_irq.h |  7 +++++++
 2 files changed, 27 insertions(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 74aaea61de13c..9a205cb033bda 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c

@@ -479,6 +479,26 @@ int of_irq_get(struct device_node *dev, int index)
 }
 EXPORT_SYMBOL_GPL(of_irq_get);
 
+const struct cpumask *of_irq_get_affinity(struct device_node *dev, int index)
+{
+	struct of_phandle_args oirq;
+	struct irq_fwspec_info info;
+	struct irq_fwspec fwspec;
+	int rc;
+
+	rc = of_irq_parse_one(dev, index, &oirq);
+	if (rc)
+		return NULL;
+
+	of_phandle_args_to_fwspec(oirq.np, oirq.args, oirq.args_count,
+				  &fwspec);
+
+	if (!irq_populate_fwspec_info(&fwspec, &info))
+		return info.affinity;

My slightly picky mental consistency filter suggests that this would look
more like the ACPI version as

	if (irq_populate_fwspec_info(&fwspec, &info))
		return NULL;

	return info.affinity;

But I don't really care.

Consistency doesn't hurt. I've applied this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.