Thread (6 messages) 6 messages, 2 authors, 2025-10-13

Re: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable

From: Siddharth Vadapalli <s-vadapalli@ti.com>
Date: 2025-10-13 11:22:44
Also in: linux-omap, linux-pci, lkml

On Mon, 2025-10-13 at 15:47 +0530, Anand Moon wrote:
Change removes the unnecessary local gpiod variable and assigns the result
of the devm_gpiod_get_optional() call directly to pcie->reset_gpio.
This makes the code more concise and readable without changing the
behavior.

Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Anand Moon <redacted>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
[TRIMMED]

I have also tested the series (despite my feedback on the first patch).
Logs:
https://gist.github.com/Siddharth-Vadapalli-at-TI/ca82a16e15a892b3349396be17b37643

Please address the feedback on the first patch.

Regards,
Siddharth.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help