Re: [PATCH v2 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children
From: André Draszik <andre.draszik@linaro.org>
Date: 2025-10-10 05:26:41
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
On Thu, 2025-10-09 at 16:25 +0100, André Draszik wrote:
quoted hunk ↗ jump to hunk
The power domains are a property of / implemented in the PMU. As such, they should be modelled as child nodes of the PMU. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Note: Ideally, the newly added properties (ranges, etc.) should only be 'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty, as they're needed only in that case. As-is, this patch now causes warnings for existing DTs as they don't specify the new properties (and they shouldn't need to). Only if DTs are updated to include power-domains, such an update should also add the new properties. I've not been able to come up with the correct schema syntax to achieve that. dependencies, dependentRequired, and dependentSchemas don't seem to support patterns. Similarly, - if: required: - ... then: required: - ... doesn't allow patterns in the 'if' block (or I didn't get the syntax right). --- .../bindings/soc/google/google,gs101-pmu.yaml | 42 +++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yamlb/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml index 209ee2f80d449c3eec568188898b3c6f7ae0ddd4..d18a351b649c0736662e67bb64de46afa01e399a 100644--- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml +++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml@@ -27,6 +27,14 @@ properties:reg: maxItems: 1 + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + + ranges: true + reboot-mode: $ref: /schemas/power/reset/syscon-reboot-mode.yaml type: object@@ -50,18 +58,50 @@ properties:description: Phandle to PMU interrupt generation interface. +patternProperties: + "^power-domain@[0-9a-f]+$": + type: object + description: Child node describing one power domain within the PMU + + additionalProperties: true + + properties: + compatible: + const: google,gs101-pd + required: - compatible - reg + - '#address-cells' + - '#size-cells' + - ranges - google,pmu-intr-gen-syscon -unevaluatedProperties: false +additionalProperties: false
Ooops, this line should have been part of patch 02 in the first place. Will fix in next version. Cheers, Andre'