Re: [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-10-10 00:35:08
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
On 09/10/2025 23:00, André Draszik wrote:
On Thu, 2025-10-09 at 14:31 +0100, André Draszik wrote:quoted
On Thu, 2025-10-09 at 09:13 +0900, Krzysztof Kozlowski wrote:quoted
On 07/10/2025 01:43, André Draszik wrote:quoted
Convert to using devm_kstrdup_const() so as to simplify cleanup during error handling.This is either a fix (then describe the fixed issue and add Fixed tag) or you change the logic, not only simplify. Previously on of_genpd_add_provider_simple() the memory was not kfree_const. Now it will be.Indeed it's a fix after all - While the driver doesn't allow unbind,Thinking more about it - at this stage, this patch is not a fix. The driver can not unbind, hence there is no leak to be plugged, hence no fix.
It is about error paths. Driver can fail binding. Best regards, Krzysztof