Re: [PATCH] drm/amd: Permit DC_FP_START/END only in non-FP compilation units

From
Ard Biesheuvel <ardb@kernel.org>
Date
2025-10-09 21:27:41
Also in
amd-gfx, dri-devel, lkml
Reply to
Harry Wentland, 2025-10-09
On Thu, 9 Oct 2025 at 13:41, Harry Wentland [off-list ref] wrote:


On 2025-10-09 12:19, Christian König wrote:
quoted
On 09.10.25 17:06, Ard Biesheuvel wrote:
quoted
From: Ard Biesheuvel <ardb@kernel.org>

Test the existing CPP macro _LINUX_FPU_COMPILATION_UNIT, which is set
when building source files that are permitted to use floating point,
in the implementation of DC_FP_START/END so that those are only usable
in non-FP code. This is a requirement of the generic kernel mode FPU
API, as some architectures (i.e., arm64) cannot safely enable FP codegen
in arbitrary code.
If I'm not completely mistaken that is actually an issue on basically all architectures, at least x86 is affected as well if I'm not completely mistaken.
quoted
Cc: Austin Zheng <austin.zheng@amd.com>
Cc: Jun Lei <jun.lei@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <siqueira@igalia.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: <redacted>
Cc: <redacted>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Anyway, patch looks sane to me but I'm not so deep in the DC code to fully judge.

Fell free to add Acked-by: Christian König [off-list ref], but Harry and Leo need to take a look.
Thanks. Good safe-guard. Flags a bunch of issues in the
current code. Let me fix them before merging it.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Thanks.

I already fixed a bunch here:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ddbfac152830e38d488ff8e45ab7eaf5d72f8527
Thread (5 messages) 5 messages, 5 authors, last reply 2025-10-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help