RE: [PATCH v4 3/5] clk: conf: Support assigned-clock-sscs

Subject: Re: [PATCH v4 3/5] clk: conf: Support assigned-clock-sscs

...

quoted

   * of_clk_set_defaults() - parse and set assigned clocks configuration
   * @node: device node to apply clock settings for @@ -174,6

+239,10

quoted

@@ int of_clk_set_defaults(struct device_node *node, bool

clk_supplier)

quoted

  	if (!node)
  		return 0;

+	rc = __set_clk_spread_spectrum(node, clk_supplier);
+	if (rc < 0)
+		return rc;
+
  	rc = __set_clk_parents(node, clk_supplier);
  	if (rc < 0)
  		return rc;

Here you are setting the clock's ssc before the setting the parent and
rate, is it possible to move it below setting of parent and rate?
because the ssc is enabled after the parent and rate is set to a clock.

The idea is setting ssc is to let driver/firmware latch the configuration,
and when set rate, the driver/firmware will configure the rate
with ssc settings. And this is what i.MX SCMI firmware implements.

Per my understanding, from hardware perspective, when setting rate,
ssc should be set together if need to enable ssc.

So TI's future platform may take NXP firmware's approach.

Thanks,
Peng. 

Thanks
Sebin