Re: [PATCH v2] i2c: mediatek: fix potential incorrect use of I2C_MASTER_WRRD
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: 2025-09-25 21:06:48
Also in:
linux-i2c, linux-mediatek, lkml
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: 2025-09-25 21:06:48
Also in:
linux-i2c, linux-mediatek, lkml
On Sat, Sep 06, 2025 at 04:24:06PM +0800, Leilk Liu wrote:
From: "Leilk.Liu" <redacted>
The old IC does not support the I2C_MASTER_WRRD (write-then-read)
function, but the current code’s handling of i2c->auto_restart may
potentially lead to entering the I2C_MASTER_WRRD software flow,
resulting in unexpected bugs.
Instead of repurposing the auto_restart flag, add a separate flag
to signal I2C_MASTER_WRRD operations.
Also fix handling of msgs. If the operation (i2c->op) is
I2C_MASTER_WRRD, then the msgs pointer is incremented by 2.
For all other operations, msgs is simply incremented by 1.
Fixes: b2ed11e224a2 ("I2C: mediatek: Add driver for MediaTek MT8173 I2C controller")
Signed-off-by: Leilk.Liu <redacted>
Suggested-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>Applied to for-next, thanks!