Re: [PATCH 1/2] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2025-09-24 08:27:08
Also in:
linux-clk, linux-devicetree, linux-mediatek, lkml
Il 24/09/25 08:05, Mikhail Kshevetskiy ha scritto:
quoted hunk ↗ jump to hunk
Introduce reset capability to EN7523 device-tree clock binding documentation. Also this patch makes mandatory '#reset-cells' property for EN7523 SoC dts. Signed-off-by: Mikhail Kshevetskiy <redacted> --- .../bindings/clock/airoha,en7523-scu.yaml | 4 +- .../dt-bindings/reset/airoha,en7523-reset.h | 61 +++++++++++++++++++ 2 files changed, 63 insertions(+), 2 deletions(-) create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.hdiff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml index fe2c5c1baf43..a0df16485300 100644 --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml@@ -53,6 +53,7 @@ required: - compatible - reg - '#clock-cells' + - '#reset-cells'
I can't find any reason why #reset-cells should be a required property: this is a clock controller, it doesn't necessarily have to provide resets, and you don't necessarily have to use resets, so this shall not be a required property.
quoted hunk ↗ jump to hunk
allOf: - if:@@ -64,8 +65,6 @@ allOf: reg: minItems: 2 - '#reset-cells': false - - if: properties: compatible:@@ -85,6 +84,7 @@ examples: reg = <0x1fa20000 0x400>, <0x1fb00000 0x1000>; #clock-cells = <1>; + #reset-cells = <1>; }; - |
Regards, Angelo