Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller
From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2025-09-23 10:13:11
Also in:
linux-devicetree, linux-mmc, lkml
On Tue, 23 Sep 2025 14:10:10 +0800, Albert Yang wrote:
Add device tree binding documentation for the Black Sesame Technologies (BST) DWCMSHC SDHCI controller. This binding describes the required and optional properties for the bst,c1200-dwcmshc-sdhci compatible controller, including register layout, interrupts, bus width, clock configuration, and other controller-specific features. Signed-off-by: Albert Yang <redacted> --- Changes for v4: - Remove Signed-off-by line for Ge Gordon - Change `$ref: mmc-controller.yaml#` to `$ref: sdhci-common.yaml#` - Change compatible string from `bst,c1200-dwcmshc-sdhci` to `bst,c1200-sdhci` Changes for v3: - Switch reg schema from maxItems to explicit items with per-entry descriptions - Improve example: add irq.h include and wrap under a bus node with address/size cells - Drop status = "disabled" from example; keep example concise - Add Signed-off-by: Ge Gordon Changes for v2: - Simplify description, remove redundant paragraphs - Update $schema to reference mmc-specific scheme - Correct compatible to add soc name (bst,c1200-dwcmshc-sdhci) - Remove all redundant property descriptions - Drop invalid mmc_crm_base/size properties, use reg for all address ranges - Clean up required properties to only essential entries - Standardize example DTS format, fix reg syntax and property ordering - Remove additionalProperties: true --- .../devicetree/bindings/mmc/bst,dwcmshc-sdhci.yaml | 70 ++++++++++++++++++++++ 1 file changed, 70 insertions(+)
My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.example.dtb: /example-0/bus/mmc@22200000: failed to match any schema with compatible: ['bst,c1200-dwcmshc-sdhci'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250923-v4-patch-final-v1-4-2283ad7cbf88@thundersoft.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.