Thread (16 messages) 16 messages, 4 authors, 2025-09-18

RE: [PATCH v6 2/5] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger

From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2025-09-18 03:41:56
Also in: linux-samsung-soc, linux-watchdog, lkml

Hi Sangwook
-----Original Message-----
From: Sangwook Shin <redacted>
Sent: Monday, August 18, 2025 7:48 AM
To: krzk@kernel.org; alim.akhtar@samsung.com; wim@linux-watchdog.org;
linux@roeck-us.net; semen.protsenko@linaro.org;
dongil01.park@samsung.com; khwan.seo@samsung.com
Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org; Sangwook Shin
[off-list ref]
Subject: [PATCH v6 2/5] watchdog: s3c2410_wdt: Fix max_timeout being
calculated larger

Fix the issue of max_timeout being calculated larger than actual value.
The calculation result of freq / (S3C2410_WTCON_PRESCALE_MAX + 1) /
S3C2410_WTCON_MAXDIV is smaller than the actual value because the
remainder is discarded during the calculation process. This leads to a larger
calculated value for max_timeout compared to the actual settable value.
To resolve this issue, the order of calculations in the computation process has
been adjusted.

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Sangwook Shin <redacted>
---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help