Thread (8 messages) 8 messages, 4 authors, 2025-09-17

Re: [PATCH v2 1/3] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible

From: Nihal Kumar Gupta <hidden>
Date: 2025-09-17 06:23:04
Also in: linux-arm-msm, linux-devicetree, linux-media, lkml


On 16-09-2025 16:41, Konrad Dybcio wrote:
quoted
quoted
Wrap commit messages at 72 chars. And explain how it's the same or 
different from existing SoCs in the commit message. Don't explain the 
diff. We can read that ourselves.
SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the 
only difference being the GPIOs used for SDA/SCL pins.

Currently, the CCI driver probe happens through the "qcom,msm8996-cci" 
compatible string. Could we use the existing SA8775P compatible string
"qcom,sa8775p-cci" or we should remove it? 

Please advise on the preferred approach for upstream compliance.
Try:

"""
The three instances of CCI found on the QCS8300 are functionally
the same as on a number of existing Qualcomm SoCs.

Introduce a new SoC-specific compatible, with a common fallback.
"""
ACK, Will address this in next version.
Konrad
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help