Re: [PATCH net-next v3 3/3] net: stmmac: dwmac-renesas-gbeth: Add support for RZ/T2H SoC
From: Anders Roxell <hidden>
Date: 2025-09-16 13:05:14
Also in:
linux-devicetree, linux-renesas-soc, lkml, netdev
On 2025-09-08 11:59, Prabhakar wrote:
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Extend the Renesas GBETH stmmac glue driver to support the RZ/T2H SoC, where the GMAC is connected through a MIIC PCS. Introduce a new `has_pcs` flag in `struct renesas_gbeth_of_data` to indicate when PCS handling is required. When enabled, the driver parses the `pcs-handle` phandle, creates a PCS instance with `miic_create()`, and wires it into phylink. Proper cleanup is done with `miic_destroy()`. New init/exit/select hooks are added to `plat_stmmacenet_data` for PCS integration. Update Kconfig to select `PCS_RZN1_MIIC` when building the Renesas GBETH driver so the PCS support is always available. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- v2->v3: - Dropped passing STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP flag in stmmac_flags as it is always set for all the SoCs. - Updated Kconfig to include RZ/T2H and RZ/N2H. v1->v2: - No changes.
The following warning is seen when doing a defconfig build (make defconfig) for arm64 on the Linux next-20250915 tag. First seen on next-20250915 Good: next-20250912 Bad: next-20250915 Regression Analysis: - New regression? yes - Reproducibility? yes Build regression: WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Reported-by: Linux Kernel Functional Testing <redacted> This is the build warning: WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Depends on [n]: NETDEVICES [=y] && OF [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST [=n]) Selected by [m]: - DWMAC_RENESAS_GBETH [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_STMICRO [=y] && STMMAC_ETH [=m] && STMMAC_PLATFORM [=m] && OF [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Depends on [n]: NETDEVICES [=y] && OF [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST [=n]) Selected by [m]: - DWMAC_RENESAS_GBETH [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_STMICRO [=y] && STMMAC_ETH [=m] && STMMAC_PLATFORM [=m] && OF [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) I: config: PASS in 0:00:01.592356 By reverting this patch the warning disapears. ## Source * Kernel version: 6.17.0-rc6 * Git tree: * https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git * Git describe: next-20250915 * Git commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e * Architectures: arm64 * Toolchains: gcc and clang * Kconfigs: lkftconfigs ## Build * Build log: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/build.log * Test details: https://regressions.linaro.org/lkft/linux-next-master/next-20250915/log-parser-build-clang/general-unmet-dependencies-warning-unmet-direct-dependencies-detected-for-pcs_rzn_miic/ * Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/ * Kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/config -- Linaro LKFT