On Mon, Sep 15, 2025 at 09:16:40AM +0200, Krzysztof Kozlowski wrote:

On 15/09/2025 09:49, Peng Fan wrote:

quoted

[...]

quoted

+static void __init exynos8890_cmu_top_init(struct device_node *np)
+{
+	exynos8890_init_clocks(np, &top_cmu_info);
+	samsung_cmu_register_one(np, &top_cmu_info);
+}
+
+/* Register CMU_TOP early, as it's a dependency for other early domains */
+CLK_OF_DECLARE(exynos8890_cmu_top, "samsung,exynos8890-cmu-top",
+	       exynos8890_cmu_top_init);

Not sure you need to run Android GKI, without module built, this platform
will not able to support GKI.

Why would anyone worry about GKI? We develop mainline kernel, not
Android kernel.

I understand this. But someone will have to update this to support module
built whether mainline or downstream tree, unless GKI is not in the plan.

This seems to be aligned with existing approach, no? What is different here?

No objection from me. I just think supporting module built is a better method.

Regards,
Peng

Best regards,
Krzysztof