Thread (8 messages) 8 messages, 4 authors, 2025-09-12

Re: [PATCH 1/2] arm64: dts: marvell: armada-37xx: Add default PCI interrup controller address cells

From: Gregory CLEMENT <gregory.clement@bootlin.com>
Date: 2025-09-12 05:21:32
Also in: linux-devicetree, lkml

Krzysztof Kozlowski [off-list ref] writes:
Add missing address-cells 0 to the PCI interrupt node to silence W=1
warning:

  armada-37xx.dtsi:518.4-521.29: Warning (interrupt_map): /soc/pcie@d0070000:interrupt-map:
    Missing property '#address-cells' in node /soc/pcie@d0070000/interrupt-controller, using 0 as fallback

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
   the fourth component "parent unit address", which size is defined by
   '#address-cells' of the node pointed to by the interrupt-parent
   component, is not used (=0)

Signed-off-by: Krzysztof Kozlowski <redacted>
Applied on mvebu/dt64

Thanks,

Gregory
quoted hunk ↗ jump to hunk
---
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 75b0fdc3efb2..c612317043ea 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -524,6 +524,7 @@ pcie0: pcie@d0070000 {
 			pcie_intc: interrupt-controller {
 				interrupt-controller;
 				#interrupt-cells = <1>;
+				#address-cells = <0>;
 			};
 		};
 	};
-- 
2.48.1
-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help