Thread (48 messages) 48 messages, 4 authors, 2025-09-12

Re: [PATCH v6 06/24] tracing: Add events to trace remotes

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-09-09 22:23:45
Also in: kvmarm, linux-trace-kernel, lkml

On Tue, 9 Sep 2025 17:47:50 -0400
Steven Rostedt [off-list ref] wrote:
quoted
 		iter->evt_cpu = cpu;
+		iter->evt = (struct remote_event_hdr *)&rb_evt->array[1];  
Hmm, shouldn't this use ring_buffer_event_data(rb_evt) instead?

If the events get big, then it would be array[2]. But the
ring_buffer_event_data() hides that detail.
Ahh, looking at the patch 10, it is always array[1].

Still should use a helper function instead of exposing the internals like
this.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help