Re: [PATCH V4 1/2] arm64/sysreg: Update TCR_EL1 register

On 08/09/25 7:28 PM, Mark Brown wrote:

On Sun, Sep 07, 2025 at 05:59:59PM +0530, Anshuman Khandual wrote:

quoted

Update TCR_EL1 register fields as per latest ARM ARM DDI 0487 L.B and while
here drop an explicit sysreg definition SYS_TCR_EL1 from sysreg.h, which is
now redundant.

I actually checked against DDI0601 2025-06 to spare my poor machine the
strain of loading the ARM.

Right, they are the same.

Reviewed-by: Mark Brown <broonie@kernel.org>

Thanks !

I guess the cleanup of the redundant definition could've been a separate
patch but it's not super important.

Dropping SYS_TCR_EL1 definition from header (asm/sysreg.h)
into a separate patch ?

#define SYS_TCR_EL1 	sys_reg(3, 0, 2, 0, 2)