Re: [PATCH] arm64: dts: allwiner: h5: OrangePi PC2: add ethernet LEDs
From: Andre Przywara <andre.przywara@arm.com>
Date: 2025-09-09 00:25:25
Also in:
linux-devicetree, linux-sunxi, lkml
On Mon, 18 Aug 2025 18:35:13 +0200 Aleksander Jan Bajkowski [off-list ref] wrote:
This patch adds support for Ethernet LEDs.
So I tried this on my OPi-PC2, but I cannot influence the LEDs. I have CONFIG_LED_TRIGGER_PHY and CONFIG_LEDS_TRIGGER_NETDEV built in, and I see mdio_mux-0.2:01:amber:lan and mdio_mux-0.2:01:green:lan in /sys/class/leds, but anything I write into trigger does not seem to change the output: it always stays on the network functionality, I guess because it's still configured to the PHY hardware wired function? What am I missing? Cheers, Andre
quoted hunk ↗ jump to hunk
Signed-off-by: Aleksander Jan Bajkowski <redacted> --- .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dtsb/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts index 0f29da7d51e6..7688f565ec9b 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts @@ -7,6 +7,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/pinctrl/sun4i-a10.h> / {@@ -132,6 +133,25 @@ &external_mdio { ext_rgmii_phy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; + + leds { + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_LAN; + linux,default-trigger = "netdev"; + }; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_AMBER>; + function = LED_FUNCTION_LAN; + linux,default-trigger = "netdev"; + }; + }; }; };