[PATCH v5 1/6] arm64: topology: Use scope-based cleanup helper
From: Zihuan Zhang <hidden>
Date: 2025-09-05 13:24:37
Also in:
dri-devel, imx, intel-gfx, linux-acpi, linux-omap, linux-pm, linuxppc-dev, lkml
Subsystem:
arm64 port (aarch64 architecture), the rest · Maintainers:
Catalin Marinas, Will Deacon, Linus Torvalds
Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy) annotation for policy references. This reduces the risk of reference counting mistakes and aligns the code with the latest kernel style. No functional change intended. Signed-off-by: Zihuan Zhang <redacted> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> --- arch/arm64/kernel/topology.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 5d07ee85bdae..07e2f5b5ade0 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c@@ -307,30 +307,27 @@ int arch_freq_get_on_cpu(int cpu) */ if (!housekeeping_cpu(cpu, HK_TYPE_TICK) || time_is_before_jiffies(last_update + msecs_to_jiffies(AMU_SAMPLE_EXP_MS))) { - struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); + struct cpufreq_policy *policy __free(put_cpufreq_policy) = + cpufreq_cpu_get(info->opp_cpu); int ref_cpu; if (!policy) return -EINVAL; if (!cpumask_intersects(policy->related_cpus, - housekeeping_cpumask(HK_TYPE_TICK))) { - cpufreq_cpu_put(policy); + housekeeping_cpumask(HK_TYPE_TICK))) return -EOPNOTSUPP; - } for_each_cpu_wrap(ref_cpu, policy->cpus, cpu + 1) { if (ref_cpu == start_cpu) { /* Prevent verifying same CPU twice */ ref_cpu = nr_cpu_ids; - break; + return -EAGAIN; } if (!idle_cpu(ref_cpu)) break; } - cpufreq_cpu_put(policy); - if (ref_cpu >= nr_cpu_ids) /* No alternative to pull info from */ return -EAGAIN;
--
2.25.1