Re: [PATCH v4 6/9] dt-bindings: clock: nxp,imx95-blk-ctl: Add ldb child node
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-09-04 07:27:33
Also in:
imx, linux-clk, linux-devicetree, lkml
On Wed, Sep 03, 2025 at 03:33:24PM +0300, Laurentiu Palcu wrote:
Since the BLK CTL registers, like the LVDS CSR, can be used to control the LVDS Display Bridge controllers, add 'ldb' child node to handle these use cases. Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com> --- .../bindings/clock/nxp,imx95-blk-ctl.yaml | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)
Nothing in the changelog explains this patch. What happened with entire previous review?
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml index 27403b4c52d62..f83d96701bb04 100644 --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml@@ -39,6 +39,28 @@ properties: ID in its "clocks" phandle cell. See include/dt-bindings/clock/nxp,imx95-clock.h +if: + properties: + compatible: + contains: + const: nxp,imx94-lvds-csr +then: + properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + patternProperties: + "^ldb@[0-9a-f]+$":
No, don't define nodes in if:then:. Where did you get this syntax from?
quoted hunk ↗ jump to hunk
+ type: object + $ref: /schemas/display/bridge/fsl,ldb.yaml# + + required: + - '#address-cells' + - '#size-cells' + required: - compatible - reg@@ -46,7 +68,7 @@ required: - power-domains - clocks -additionalProperties: false +unevaluatedProperties: false
NAK, so schema warned you above syntax is wrong and you decided to silence the warning with this hack, right? Best regards, Krzysztof