Re: [PATCH 02/11] dmaengine: imx-sdma: sdma_remove minor cleanups
From: Frank Li <Frank.li@nxp.com>
Date: 2025-09-03 14:50:27
Also in:
dmaengine, imx, lkml
On Wed, Sep 03, 2025 at 03:06:10PM +0200, Marco Felsch wrote:
We don't need to set the pdev driver data to NULL since the device will be freed anyways. Also drop the tasklet_kill() since this is done by the virt-dma driver during the vchan_synchronize(). Signed-off-by: Marco Felsch <redacted>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
--- drivers/dma/imx-sdma.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 89b4b1266726a9c8a552dc48670825ae00717e1c..422086632d3445b2ce3f2e5df9b2130174a311e8 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c@@ -2423,11 +2423,8 @@ static void sdma_remove(struct platform_device *pdev) for (i = 0; i < MAX_DMA_CHANNELS; i++) { struct sdma_channel *sdmac = &sdma->channel[i]; - tasklet_kill(&sdmac->vc.task); sdma_free_chan_resources(&sdmac->vc.chan); } - - platform_set_drvdata(pdev, NULL); } static struct platform_driver sdma_driver = { --2.47.2