Re: [PATCH net-next v2 2/8] dt-bindings: remoteproc: k3-r5f: Add rpmsg-eth subnode
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-09-03 12:54:17
Also in:
linux-devicetree, linux-doc, linux-remoteproc, lkml, netdev
On 03/09/2025 09:57, MD Danish Anwar wrote:
quoted
quoted
Signed-off-by: MD Danish Anwar <danishanwar@ti.com> --- .../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml index a492f74a8608..4dbd708ec8ee 100644 --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml@@ -210,6 +210,12 @@ patternProperties: should be defined as per the generic bindings in, Documentation/devicetree/bindings/sram/sram.yaml + rpmsg-eth: + $ref: /schemas/net/ti,rpmsg-eth.yamlNo, not a separate device. Please read slides from my DT for beginnersI had synced with Andrew and we came to the conclusion that including rpmsg-eth this way will follow the DT guidelines and should be okay.
... and did you check the guidelines? Instead of repeating something not related to my comment rather bring argument matching the comment. ...
quoted hunk ↗ jump to hunk
@@ -768,6 +774,7 @@ &main_r5fss0_core0 { mboxes = <&mailbox0_cluster2 &mbox_main_r5fss0_core0>; memory-region = <&main_r5fss0_core0_dma_memory_region>, <&main_r5fss0_core0_memory_region>; + rpmsg-eth-region = <&main_r5fss0_core0_memory_region_shm>;
You already have here memory-region, so use that one.
};
&main_r5fss0_core1 {
In this approach I am creating a new phandle to a memory region that
will be used by my device.Best regards, Krzysztof