Thread (13 messages) 13 messages, 4 authors, 2025-09-02

Re: [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more

From: Guenter Roeck <linux@roeck-us.net>
Date: 2025-09-02 19:06:50
Also in: linux-devicetree, linux-samsung-soc, linux-watchdog, lkml

On Sat, Aug 30, 2025 at 12:19:00PM +0200, Krzysztof Kozlowski wrote:
Binding defined two if:then: blocks covering different conditions but
not fully constraining the properties per each variant:
1. "if:" to require samsung,syscon-phandle,
2. "if:" with "else:" to narrow number of clocks and require or disallow
   samsung,cluster-index.

This still did not cover following cases:
1. Disallow samsung,syscon-phandle when not applicable,
2. Narrow samsung,cluster-index to [0, 1], for SoCs with only two
   clusters.

Solving this in current format would lead to spaghetti code, so re-write
entire "if:then:" approach into mutually exclusive cases so each SoC
appears only in one "if:" block.  This allows to forbid
samsung,syscon-phandle for S3C6410, and narrow samsung,cluster-index
to [0, 1].

Signed-off-by: Krzysztof Kozlowski <redacted>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help