Re: [PATCH v3 2/3] pinctrl: bcm: Add STB family pin controller driver

Hi Stefan,

On 11:18 Tue 19 Aug     , Stefan Wahren wrote:

Hi Andrea,

Am 11.08.25 um 16:46 schrieb Andrea della Porta:

quoted

From: "Ivan T. Ivanov" <redacted>

This driver provide pin muxing and configuration functionality
for BCM2712 SoC used by RPi5. According to [1] this chip is an
instance of the one used in Broadcom STB  product line.

i'm not sure about the whole driver naming. The cover letter describe it as
"pin control driver for BCM2712 SoC", but this patch is described as "STB
family pin controller driver". So as a reviewer, I'm a little bit confused
of the domain of this driver. Is it for a single SoC or really for a whole
family of many SoCs?

It seems that this is indeed a whole family of which BCM2712 is the (first?)
incarnation. I'm not really aware whether there exist other physical
implementations but I'll amend the comment accordingly.
Please also see:
https://lore.kernel.org/lkml/d6ab66cf-09ac-4f53-9102-11f207d16db5@broadcom.com/ (local)

Many thanks,
Andrea

I'm asking because all the other BCM pinctrl drivers are mostly SoC specific
and not really general for a product line.

In the former case, I would expect a driver name like pinctrl-bcm2712 to
make it more clear.

Best regards