Re: [PATCH v2] clk: scmi: migrate round_rate() to determine_rate()

On Fri, Aug 29, 2025 at 10:59:15AM +0100, Sudeep Holla wrote:

On Fri, Aug 29, 2025 at 06:09:03PM +0800, Peng Fan wrote:

quoted

On Wed, Aug 27, 2025 at 01:12:07PM -0400, Brian Masney wrote:

quoted

This driver implements both the determine_rate() and round_rate() clk
ops, and the round_rate() clk ops is deprecated. When both are defined,
clk_core_determine_round_nolock() from the clk core will only use the
determine_rate() clk ops.

The existing scmi_clk_determine_rate() is a noop implementation that
lets the firmware round the rate as appropriate. Drop the existing
determine_rate implementation and convert the existing round_rate()
implementation over to determine_rate().

scmi_clk_determine_rate() was added recently when the clock parent
support was added, so it's not expected that this change will regress
anything.

Signed-off-by: Brian Masney <bmasney@redhat.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Peng,

It would be great if you can test it with parent clock support on i.MX
platforms just to be sure this doesn't regress anything.

Just gave a test on i.MX95-EVK, it boots well and eth0 works, 
the results in /sys/kernel/debug/clk/clk_summary also looks correct.

Tested-by: Peng Fan <peng.fan@nxp.com> #i.MX95-19x19-EVK

Regards
Peng

-- 
Regards,
Sudeep