Re: [PATCH v1 13/36] mm/hugetlb: cleanup hugetlb_folio_init_tail_vmemmap()
From: David Hildenbrand <hidden>
Date: 2025-08-29 12:00:48
Also in:
dri-devel, intel-gfx, io-uring, kvm, linux-crypto, linux-ide, linux-iommu, linux-kselftest, linux-mips, linux-mm, linux-mmc, linux-riscv, linux-s390, linux-scsi, lkml, netdev, virtualization
On 28.08.25 10:37, Mike Rapoport wrote:
On Thu, Aug 28, 2025 at 10:18:23AM +0200, David Hildenbrand wrote:quoted
On 28.08.25 10:06, Mike Rapoport wrote:quoted
On Thu, Aug 28, 2025 at 09:44:27AM +0200, David Hildenbrand wrote:quoted
On 28.08.25 09:21, Mike Rapoport wrote:quoted
On Thu, Aug 28, 2025 at 12:01:17AM +0200, David Hildenbrand wrote:quoted
+ /* + * We mark all tail pages with memblock_reserved_mark_noinit(), + * so these pages are completely uninitialized.^ not? ;-)Can you elaborate?Oh, sorry, I misread "uninitialized". Still, I'd phrase it as /* * We marked all tail pages with memblock_reserved_mark_noinit(), * so we must initialize them here. */I prefer what I currently have, but thanks for the review.No strong feelings, feel free to add Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
I now have "As we marked all tail pages with memblock_reserved_mark_noinit(), we must initialize them ourselves here." -- Cheers David / dhildenb