Thread (11 messages) 11 messages, 2 authors, 2025-08-30

RE: [PATCH 1/4] arm64: dts: exynos5433: Add default GIC address cells

From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2025-08-29 11:03:30
Also in: linux-devicetree, linux-samsung-soc, lkml

Hi Krzysztof
-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Friday, August 22, 2025 5:44 PM
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>; Rob Herring
[off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor
Dooley [off-list ref]; Alim Akhtar [off-list ref];
Peter Griffin [off-list ref]; André Draszik
[off-list ref]; Tudor Ambarus [off-list ref];
linux-fsd@tesla.com; linux-arm-kernel@lists.infradead.org; linux-samsung-
soc@vger.kernel.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <redacted>
Subject: [PATCH 1/4] arm64: dts: exynos5433: Add default GIC address cells

Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:

  exynos5433-tm2-common.dtsi:1000.2-41: Warning (interrupt_map):
/soc@0/pcie@15700000:interrupt-map:
    Missing property '#address-cells' in node /soc@0/interrupt-
controller@11001000, using 0 as fallbac

Value '0' is correct because:
1. GIC interrupt controller does not have children, 2. interrupt-map property
(in PCI node) consists of five components and
   the fourth component "parent unit address", which size is defined by
   '#address-cells' of the node pointed to by the interrupt-parent
   component, is not used (=0).

Signed-off-by: Krzysztof Kozlowski <redacted>
---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
quoted hunk ↗ jump to hunk
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 0b9053b9b2b5..fa2029e280a5 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -937,6 +937,7 @@ reboot: syscon-reboot {

 		gic: interrupt-controller@11001000 {
 			compatible = "arm,gic-400";
+			#address-cells = <0>;
 			#interrupt-cells = <3>;
 			interrupt-controller;
 			reg = <0x11001000 0x1000>,
--
2.48.1


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help