Re: [PATCH v4 01/13] spi: airoha: return an error for continuous mode dirmap creation cases
From: Lorenzo Bianconi <lorenzo@kernel.org>
Date: 2025-08-23 08:04:23
Also in:
linux-spi, lkml
This driver can accelerate single page operations only, thus continuous reading mode should not be used. Continuous reading will use sizes up to the size of one erase block. This size is much larger than the size of single flash page. Use this difference to identify continuous reading and return an error. Signed-off-by: Mikhail Kshevetskiy <redacted> Reviewed-by: Frieder Schrempf <redacted>
I guess here we need to add the proper Fixes tag:
Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver")
quoted hunk ↗ jump to hunk
--- drivers/spi/spi-airoha-snfi.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index dbe640986825..043a03cd90a1 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c@@ -618,6 +618,10 @@ static int airoha_snand_dirmap_create(struct spi_mem_dirmap_desc *desc) if (desc->info.offset + desc->info.length > U32_MAX) return -EINVAL; + /* continuous reading is not supported */ + if (desc->info.length > SPI_NAND_CACHE_SIZE) + return -E2BIG; + if (!airoha_snand_supports_op(desc->mem, &desc->info.op_tmpl)) return -EOPNOTSUPP;-- 2.50.1
Attachments
- signature.asc [application/pgp-signature] 228 bytes