Thread (19 messages) 19 messages, 3 authors, 2025-08-21

Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node

From: Yijie Yang <hidden>
Date: 2025-08-20 08:57:48
Also in: linux-arm-msm, linux-devicetree, lkml, netdev


On 2025-08-19 17:08, Krzysztof Kozlowski wrote:
On 19/08/2025 11:04, Yijie Yang wrote:
quoted

On 2025-08-19 15:15, Krzysztof Kozlowski wrote:
quoted
On 19/08/2025 08:51, Yijie Yang wrote:
quoted

On 2025-08-19 14:44, Krzysztof Kozlowski wrote:
quoted
On 19/08/2025 08:35, YijieYang wrote:
quoted
From: Yijie Yang <redacted>

Add an ethernet controller node for QCS615 SoC to enable ethernet
functionality.

Reviewed-by: Konrad Dybcio <redacted>
Signed-off-by: Yijie Yang <redacted>
---

Why do you mix up DTS and net-next patches? This only makes difficult to
apply it, for no benefits.
The DTS changes and driver code modifications work together to achieve a
single purpose, so I included them in one patch series. Should I
consider splitting them into two separate series?
Of course yes. You are just making difficult to apply this. Patches are
completely independent and even your internal guideline asks to NOT
combine independent patches.
The challenge with splitting this series lies in the fact that it
attempts to reverse the incorrect semantics of phy-mode in both the
driver code and the device tree. Selecting only part of the series would
break Ethernet functionality on both boards.
And where did you explain that? Anyway, you did not achieve your goal,
because you broke the boards still.

Your patchset is not bisectable and does not follow standard submission
guidelines. DTS is always independent, please read carefully the docs.
The approach I'm taking will inevitably make the series non-bisectable, 
but I'll clearly note this in the cover letter in the next revision.
quoted
As you can see, I’ve CC’d noautosel to prevent this issue. Given the
circumstances, I’m wondering if it would be acceptable to leave the
series as-is?
NAK. Sneaking DTS into net-next is not acceptable.
Okay, I’ll split this series in the next revision.

Best regards,
Krzysztof
-- 
Best Regards,
Yijie

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help