Thread (7 messages) flat view 7 messages, 4 authors, 2025-08-21

Re: [PATCH 2/4] pinctrl: pinctrl-zynqmp: use kcalloc() instead of kzalloc()

From: Michal Simek <michal.simek@amd.com>
Date: 2025-08-20 08:02:41
Also in: linux-gpio, lkml


On 8/19/25 16:39, Qianfeng Rong wrote:
quoted hunk ↗ jump to hunk
Use devm_kcalloc() in versal_pinctrl_prepare_pin_desc() to gain built-in
overflow protection, making memory allocation safer when calculating
allocation size compared to explicit multiplication.

Signed-off-by: Qianfeng Rong <redacted>
---
  drivers/pinctrl/pinctrl-zynqmp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
index 71eaac81deb1..aba129ead04c 100644
--- a/drivers/pinctrl/pinctrl-zynqmp.c
+++ b/drivers/pinctrl/pinctrl-zynqmp.c
@@ -918,7 +918,7 @@ static int versal_pinctrl_prepare_pin_desc(struct device *dev,
  	if (ret)
  		return ret;
  
-	pins = devm_kzalloc(dev, sizeof(*pins) * *npins, GFP_KERNEL);
+	pins = devm_kcalloc(dev, *npins, sizeof(*pins), GFP_KERNEL);
  	if (!pins)
  		return -ENOMEM;
  
Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help