Re: [PATCH v1 6/6] spi: s3c64xx: Remove the use of dev_err_probe()
From: Tudor Ambarus <tudor.ambarus@linaro.org>
Date: 2025-08-19 10:00:06
Also in:
linux-samsung-soc, linux-spi, lkml
On 8/19/25 10:20 AM, Xichao Zhao wrote:
The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore, remove the useless call to dev_err_probe(), and just return the value instead. Signed-off-by: Xichao Zhao <redacted>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
quoted hunk ↗ jump to hunk
--- drivers/spi/spi-s3c64xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b1567243ae19..3a00f9e480c5 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -1268,8 +1268,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) host = devm_spi_alloc_host(&pdev->dev, sizeof(*sdd)); if (!host) - return dev_err_probe(&pdev->dev, -ENOMEM, - "Unable to allocate SPI Host\n"); + return -ENOMEM; platform_set_drvdata(pdev, host);