Re: [PATCH] dt-bindings: mmc: Add compatible for MT8189 SoC
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-18 12:17:33
Also in:
linux-devicetree, linux-mediatek, linux-mmc, lkml
On 18/08/2025 13:47, Mengqi Zhang wrote:
Add a compatible string for the MT8189 SoC's mtk-sd mmc controllers.
Where is any user of that?
quoted hunk ↗ jump to hunk
Signed-off-by: Mengqi Zhang <redacted> --- .../devicetree/bindings/mmc/mtk-sd.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+)diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 6dd26ad31491..1285dddeaec9 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml@@ -25,6 +25,7 @@ properties: - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc + - mediatek,mt8189-mmc - mediatek,mt8196-mmc - mediatek,mt8516-mmc - items:@@ -192,6 +193,7 @@ allOf: - mediatek,mt8183-mmc - mediatek,mt8186-mmc - mediatek,mt8188-mmc + - mediatek,mt8189-mmc
huh? This sets the clocks
quoted hunk ↗ jump to hunk
- mediatek,mt8195-mmc - mediatek,mt8196-mmc - mediatek,mt8516-mmc@@ -240,6 +242,7 @@ allOf: - mediatek,mt7986-mmc - mediatek,mt7988-mmc - mediatek,mt8183-mmc + - mediatek,mt8189-mmc - mediatek,mt8196-mmc then: properties:@@ -319,6 +322,32 @@ allOf: - const: source_cg - const: crypto + - if: + properties: + compatible: + contains: + const: mediatek,mt8189-mmc + then: + properties: + clocks: + items:
As this as well.. And obviously never tested. Please don't send untested (and buggy) code :(. Why do you think reviewers should spend time on it instead of tools? Best regards, Krzysztof