Re: [PATCH v3 5/7] media: qcom: camss: enable vfe 690 for qcs8300
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2025-08-13 21:35:27
Also in:
linux-arm-msm, linux-devicetree, linux-media, lkml
On 13/08/2025 06:37, Vikram Sharma wrote:
quoted hunk ↗ jump to hunk
The vfe in qcs8300 is version 690, it is same as vfe used in lemans(sa8775p). vfe gen3 have support for vfe 690. Signed-off-by: Vikram Sharma <redacted> --- drivers/media/platform/qcom/camss/camss-vfe-gen3.c | 3 ++- drivers/media/platform/qcom/camss/camss-vfe.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)diff --git a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c index f2001140ead1..22579617def7 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c@@ -13,7 +13,8 @@ #include "camss-vfe.h" #define IS_VFE_690(vfe) \ - (vfe->camss->res->version == CAMSS_8775P) + ((vfe->camss->res->version == CAMSS_8775P) \ + || (vfe->camss->res->version == CAMSS_8300))
I'd really prefer a patch setting the CSID and VFE versions as properties of their respective data-structures. BUT, again this will do for now.
quoted hunk ↗ jump to hunk
#define BUS_REG_BASE_690 \ (vfe_is_lite(vfe) ? 0x480 : 0x400)diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 99cbe09343f2..1d40184d7d04 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c@@ -344,6 +344,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code, case CAMSS_8x96: case CAMSS_8250: case CAMSS_8280XP: + case CAMSS_8300: case CAMSS_845: case CAMSS_8550: case CAMSS_8775P:@@ -1974,6 +1975,7 @@ static int vfe_bpl_align(struct vfe_device *vfe) case CAMSS_7280: case CAMSS_8250: case CAMSS_8280XP: + case CAMSS_8300: case CAMSS_845: case CAMSS_8550: case CAMSS_8775P:
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>