Re: [PATCH v2 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
From: Krzysztof Kozlowski <hidden>
Date: 2025-08-11 08:08:01
Also in:
linux-devicetree, linux-media, linux-mediatek, lkml
On Mon, Aug 11, 2025 at 11:26:14AM +0800, Kyrie Wu wrote:
quoted hunk ↗ jump to hunk
Add MT8189 encoder compatible string to distinguish former ICs MTK's. Compared with MT8196, the maximum resolution of MT8189 encoder is only 4K, and the fps is only 30, which cannot reach the highest parameter of MT8196: level6.2, 8K@60fps. Compared with MT8188, the level can only support 5.1, which is less than 5.2 of MT8188. But the maximum bitrate is 100Mbps, which is twice that of MT8188. And MT8189 could support NBM mode. Signed-off-by: Kyrie Wu <redacted> Acked-by: Krzysztof Kozlowski <redacted> --- .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 2 ++ 1 file changed, 2 insertions(+)diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index 7675391d7eb0..faee838d684e 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml@@ -25,6 +25,7 @@ properties: - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc - mediatek,mt8196-vcodec-enc + - mediatek,mt8189-vcodec-enc
Same issue... you got these comments on your v1 of your other patchset, didn't you? Best regards, Krzysztof