Re: [PATCH v4 2/4] watchdog: s3c2410_wdt: Fix max_timeout being calculated larger
From: Guenter Roeck <linux@roeck-us.net>
Date: 2025-08-05 13:30:33
Also in:
linux-samsung-soc, linux-watchdog, lkml
From: Guenter Roeck <linux@roeck-us.net>
Date: 2025-08-05 13:30:33
Also in:
linux-samsung-soc, linux-watchdog, lkml
On 8/5/25 00:26, sw617.shin@samsung.com wrote:
On Tuesday, August 5, 2025 at 2:03 PM Sam Protsenko [off-list ref] wrote:quoted
quoted
quoted
+ u64 t_max = n_max / freq;Make sure this compiles on 32-bit builds.Can you please elaborate what might be the possible problem -- just curious? I admit I never though about 32-bit case when writing that code, but don't see any immediate issues with that too.In my opinion, it seems that Gunter Reck's explanation is correct. I've found out that the error of "undefined reference to '__aeabi_uldivmod'" may occur when compiling new code on a 32-bit architecture.
Also see include/linux/math64.h. The functions implemented or declared in that include file do have a reason to exist. Guenter