Re: [PATCH v3 29/29] iommu/arm-smmu-v3-kvm: Add IOMMU ops
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2025-07-30 14:42:55
Also in:
kvmarm, linux-iommu, lkml
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2025-07-30 14:42:55
Also in:
kvmarm, linux-iommu, lkml
On Mon, Jul 28, 2025 at 05:53:16PM +0000, Mostafa Saleh wrote:
Register the SMMUv3 through IOMMU ops, that only support identity domains. This allows the driver to know which device are currently used to properly enable/disable then. Signed-off-by: Mostafa Saleh <smostafa@google.com> --- .../iommu/arm/arm-smmu-v3/arm-smmu-v3-kvm.c | 92 ++++++++++++++++++- 1 file changed, 91 insertions(+), 1 deletion(-)
Can you split the new iommu subysstem driver out please? I think I asked this before. This series is big, reviewing a new iommu driver should be done separately. Please review all the comments for the verisilicon driver, I think many of the remarks apply here too: - Domain attachment looks questionable. Please do not have attach/detach language at all in the hypervisor facing API. - Get the ordering and APIs right so replace works. You need this to support RMRs - Use a blocking domain not some unclear detatch idea - Use a blocking domain for release - Use the smmu-v3 approach for the fwspec, don't store things in the drvdata. Jason