Re: [PATCH net v2 1/4] auxiliary: Support hexadecimal ids
From: Sean Anderson <sean.anderson@linux.dev>
Date: 2025-07-21 14:29:39
Also in:
lkml, netdev
From: Sean Anderson <sean.anderson@linux.dev>
Date: 2025-07-21 14:29:39
Also in:
lkml, netdev
On 7/20/25 04:17, Leon Romanovsky wrote:
On Thu, Jul 17, 2025 at 01:12:08PM -0400, Sean Anderson wrote:quoted
On 7/17/25 12:33, Greg Kroah-Hartman wrote:<...>quoted
Anyway, if you really think ids should be random or whatever, why not just ida_alloc one in axiliary_device_init and ignore whatever's provided? I'd say around half the auxiliary drivers just use 0 (or some other constant), which is just as deterministic as using the device address.I would say that auxiliary bus is not right fit for such devices. This bus was introduced for more complex devices, like the one who has their own ida_alloc logic.
I'd say that around 2/3 of the auxiliary drivers that have non-constant ids use ida_alloc solely for the auxiliary bus and for no other purpose. I don't think that's the kind of complexity you're referring to.
quoted
Another third use ida_alloc (or xa_alloc) so all that could be removed.These ID numbers need to be per-device.
Why? They are arbitrary with no semantic meaning, right? --Sean