On 2025/7/2 23:27, Leo Yan wrote:

On Fri, Jun 20, 2025 at 03:54:10PM +0800, Junhao He wrote:

quoted

From: Yicong Yang <yangyicong@hisilicon.com>

tmc_drvdata::reading is used to indicate whether a reading process
is performed through /dev/xyz.tmc. Document it.

Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Junhao He <redacted>
---
  drivers/hwtracing/coresight/coresight-tmc.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
index 6541a27a018e..3ca0d40c580d 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.h
+++ b/drivers/hwtracing/coresight/coresight-tmc.h

@@ -220,6 +220,7 @@ struct tmc_resrv_buf {
   * @pid:	Process ID of the process that owns the session that is using
   *		this component. For example this would be the pid of the Perf
   *		process.
+ * @reading:	buffer's in the reading through "/dev/xyz.tmc" entry

Are you working on the latest code base? For example, the mainline
kernel or coresight next branch.
The latest code already has comment for reading, and I saw a duplicated
"reading" field in tmc_drvdata.

This patch is based on mainline kernel v6.16-rc1, and adds a comment to 
struct tmc_drvdata::reading.
Perhaps, this git log could easily be misunderstood as adding comments 
to tmc_resrv_buf::reading.

The tmc_resrv_buf structure does not have the fields "pid",
"stop_on_flush", "buf", etc. They have been moved into the tmc_drvdata
structure.

Thanks,
Leo

quoted

   * @stop_on_flush: Stop on flush trigger user configuration.
   * @buf:	Snapshot of the trace data for ETF/ETB.
   * @etr_buf:	details of buffer used in TMC-ETR
-- 
2.33.0

_______________________________________________
CoreSight mailing list -- coresight@lists.linaro.org
To unsubscribe send an email to coresight-leave@lists.linaro.org
.