Re: [PATCH 10/10] ASoC: dt-bindings: mediatek,mt8189-nau8825: add mt8189-nau8825 document

On Sat, 2025-06-28 at 14:42 +0200, Krzysztof Kozlowski wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


On 28/06/2025 09:14, Cyril wrote:

quoted

From: Cyril Chao <redacted>

Add document for mt8189 board with nau8825.

Signed-off-by: Cyril Chao <redacted>

Why does the binding come after user? Follow submitting patches in
DT.

Could you help to clarify this? Is it the order in which I submitted
the dt-binding patch that's incorrect? Much thanks~~

quoted

---
 .../sound/mediatek,mt8189-nau8825.yaml        | 103
++++++++++++++++++
 1 file changed, 103 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/sound/mediatek,mt8189-
nau8825.yaml

diff --git
a/Documentation/devicetree/bindings/sound/mediatek,mt8189-
nau8825.yaml
b/Documentation/devicetree/bindings/sound/mediatek,mt8189-
nau8825.yaml
new file mode 100644
index 000000000..331c537d3

--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189-

nau8825.yaml

@@ -0,0 +1,103 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: 

https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BLVZS00w$
+$schema: 
https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BzAjmYYE$
+
+title: MediaTek MT8189 ASoC sound card
+
+maintainers:
+  - Darren Ye [off-list ref]
+  - Cyril Chao [off-list ref]
+
+allOf:
+  - $ref: sound-card-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt8189-nau8825-sound
+      - mediatek,mt8189-rt5650-sound
+      - mediatek,mt8189-rt5682s-sound
+      - mediatek,mt8189-rt5682i-sound

Sound is redundant. Can it be anything else?

Okay, I will remove 'sound' next version, and like this:
mediatek,mt8189-nau8825
mediatek,mt8189-rt5650
mediatek,mt8189-rt5682s
mediatek,mt8189-rt5682i

Thanks for review~~~

Best Regards
Cyril Chao

Best regards,
Krzysztof