Thread (7 messages) 7 messages, 3 authors, 2025-07-14

RE: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700 binding description and example

From: Ryan Chen <ryan_chen@aspeedtech.com>
Date: 2025-07-14 09:42:53
Also in: linux-aspeed, linux-devicetree, lkml

Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700
binding description and example

On 14/07/2025 10:23, Krzysztof Kozlowski wrote:
quoted
On 14/07/2025 09:36, Ryan Chen wrote:
quoted
quoted
Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed:
Refine AST2700 binding description and example

On 14/07/2025 09:17, Ryan Chen wrote:
quoted
- Update block diagram for better readability and accuracy.
- Clarify the relationship and function of INTC0, INTC1, and the GIC.
- Documentation and example refine.

This enhances the documentation quality and helps developers
understand the interrupt controller hierarchy and usage.
Changing ABI (compatibles) is not enhancing quality and is not explained
here.
quoted
quoted
quoted
Sorry, I would add following in description.
- add 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible
strings for parent interrupt controller nodes, in addition to the
existing 'aspeed,ast2700-intc-ic' for child nodes.
It does not say why is this needed in the first place...
And also never tested :/. I won't be reviewing it.
Thanks, will update example and test it, and send v2

Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help